Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/tcp_client_socket_pool.cc

Issue 1716007: Cleanup: Address some of the todos in net_log.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_libevent.cc ('k') | net/socket/tcp_client_socket_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_client_socket_pool.cc
===================================================================
--- net/socket/tcp_client_socket_pool.cc (revision 45472)
+++ net/socket/tcp_client_socket_pool.cc (working copy)
@@ -200,9 +200,13 @@
static_cast<const TCPSocketParams*>(params);
if (net_log.HasListener()) {
- net_log.AddString(StringPrintf("Requested TCP socket to: %s [port %d]",
- casted_params->destination().hostname().c_str(),
- casted_params->destination().port()));
+ // TODO(eroman): Split out the host and port parameters.
+ net_log.AddEventWithString(
+ NetLog::TYPE_TCP_CLIENT_SOCKET_POOL_REQUESTED_SOCKET,
+ "host_and_port",
+ StringPrintf("%s [port %d]",
+ casted_params->destination().hostname().c_str(),
+ casted_params->destination().port()));
}
return base_.RequestSocket(group_name, *casted_params, priority, handle,
« no previous file with comments | « net/socket/tcp_client_socket_libevent.cc ('k') | net/socket/tcp_client_socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698