Cleanup: Address some of the todos in net_log.h...

net/proxy/proxy_service.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_service.h"
 
 #include <algorithm>
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
@@ skipping 451 matching lines @@
   pending_requests_.erase(it);
 }
 
 int ProxyService::DidFinishResolvingProxy(ProxyInfo* result,
                                           int result_code,
                                           const BoundNetLog& net_log) {
   // Log the result of the proxy resolution.
   if (result_code == OK) {
     // When full logging is enabled, dump the proxy list.
     if (net_log.HasListener()) {
-      net_log.AddString(
-          std::string("Resolved proxy list: ") + result->ToPacString());
+      net_log.AddEventWithString(
+          NetLog::TYPE_PROXY_SERVICE_RESOLVED_PROXY_LIST,
+          "pac_string", result->ToPacString());
     }
     result->DeprioritizeBadProxies(proxy_retry_info_);
   } else {
-    net_log.AddString(StringPrintf(
-        "Got an error from proxy resolver (%d), falling-back to DIRECT.",
-        result_code));
+    net_log.AddEventWithInteger(
+        NetLog::TYPE_PROXY_SERVICE_RESOLVED_PROXY_LIST,
+        "net_error", result_code);
 
     // Fall-back to direct when the proxy resolver fails. This corresponds
     // with a javascript runtime error in the PAC script.
     //
     // This implicit fall-back to direct matches Firefox 3.5 and
     // Internet Explorer 8. For more information, see:
     //
     // http://www.chromium.org/developers/design-documents/proxy-settings-fallback
     result->UseDirect();
     result_code = OK;
@@ skipping 249 matching lines @@
     OnCompletion(result_);
   }
 }
 
 void SyncProxyServiceHelper::OnCompletion(int rv) {
   result_ = rv;
   event_.Signal();
 }
 
 }  // namespace net