Issue 1714004: Removed direct inclusion of GL headers from gl_utils.h....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1714004: Removed direct inclusion of GL headers from gl_utils.h.... (Closed)

Created:
10 years, 8 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Removed direct inclusion of GL headers from gl_utils.h. Now they are included indirectly via glew. This caused a problem for some people building for linux. TEST=trybots BUG=41039 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45338

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	gpu/command_buffer/service/gl_utils.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Ken Russell (switch to Gerrit)

10 years, 8 months ago (2010-04-22 19:09:30 UTC) #2

LGTM as long as everything still builds.