Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1712025: Use ScopedVector instead of dynamically allocated array. (Closed)

Created:
10 years, 7 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev, Mads Ager (chromium), Alexander Potapenko
Visibility:
Public.

Description

Use ScopedVector instead of dynamically allocated array. This ensures that it'll be released on any control path leaving the function thanks to desctuctor semantics. BUG=42925 Committed: http://code.google.com/p/v8/source/detail?r=4554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/runtime.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Misha, may you have a look? Guys, if I correctly use ScopedVector, I'll go over ...
10 years, 7 months ago (2010-04-30 10:22:32 UTC) #1
mnaganov (inactive)
10 years, 7 months ago (2010-04-30 10:24:42 UTC) #2
On 2010/04/30 10:22:32, antonm wrote:
> Misha,
> 
> may you have a look?
> 
> Guys, if I correctly use ScopedVector, I'll go over rest of NewArray usages to
> audit them and probably turn some into ScopedVector.

LGTM. I appreciate your initiative!

Powered by Google App Engine
This is Rietveld 408576698