Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1712018: Vboot Reference: Remove dependency on TrouSers by not including tss/tcs.h (Closed)

Created:
10 years, 8 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Luigi Semenzato
CC:
chromium-os-reviews_chromium.org, gauravsh
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Vboot Reference: Remove dependency on TrouSers by not including tss/tcs.h Use "tss_constants.h" with TPM data type and constant definitions instead.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add FIXmes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M src/platform/vboot_reference/common/include/tlcl.h View 1 chunk +9 lines, -0 lines 0 comments Download
A src/platform/vboot_reference/common/include/tss_constants.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/common/rollback_index.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/common/tlcl_stub.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gauravsh
10 years, 8 months ago (2010-04-27 22:54:54 UTC) #1
Luigi Semenzato
No easy way to share that file? Don't you already have to include tlcl.h from ...
10 years, 8 months ago (2010-04-27 23:03:13 UTC) #2
gauravsh
http://codereview.chromium.org/1712018/diff/1/2 File src/platform/vboot_reference/common/include/tss_constants.h (right): http://codereview.chromium.org/1712018/diff/1/2#newcode63 src/platform/vboot_reference/common/include/tss_constants.h:63: #endif /* TPM_LITE_TSS_CONSTANTS_H_ */ On 2010/04/27 23:03:13, Luigi Semenzato ...
10 years, 8 months ago (2010-04-27 23:06:28 UTC) #3
Luigi Semenzato
10 years, 8 months ago (2010-04-27 23:18:39 UTC) #4
LGTM after you add comments to those files that we're copying around just
because we don't fit with the standard build scheme.

Powered by Google App Engine
This is Rietveld 408576698