Added third_party/angleproject to SPECIAL_CASES becuase it is checked-out dir...

Added third_party/angleproject to SPECIAL_CASES becuase it is checked-out directly from upstream. FYI licenses.py is still complaining about missing README.chromium for SPECIAL_CASES. 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45989

[Evan Martin, 2010-04-26 17:16:18]

I patched this in and got:

third_party/angleproject: License file not found. Either add a file named
LICENSE, import upstream's COPYING if available, or add a 'License File:' line
to README.chromium with the appropriate path.


Which is true -- I don't see a license.

[Evan Martin, 2010-04-26 17:16:52]

On 2010/04/26 17:16:18, Evan Martin wrote:
> I patched this in and got:
> 
> third_party/angleproject: License file not found. Either add a file named
> LICENSE, import upstream's COPYING if available, or add a 'License File:' line
> to README.chromium with the appropriate path.
> 
> 
> Which is true -- I don't see a license.

(In the other SPECIAL_CASES they either include a LICENSE file or the metadata
has a path to the license file.)

[alokp, 2010-04-29 19:55:48]

third_party/angleproject has now been renamed to third_party/angle and it has a
LICENSE file. BTW "liceses.py scan" is still complaining about README.chromium.
Am I missing something?

[Evan Martin, 2010-04-29 20:16:39]

On 2010/04/29 19:55:48, alokp wrote:
> third_party/angleproject has now been renamed to third_party/angle and it has
a
> LICENSE file. BTW "liceses.py scan" is still complaining about
README.chromium.
> Am I missing something?

What is the error message?  It looks ok to me...

[alokp, 2010-04-29 20:20:11]

third_party/angle: missing README.chromium

I added third_party/angle to SPECIAL_CASES. That should have fixed it. right?

[Evan Martin, 2010-04-29 20:24:12]

On 2010/04/29 20:20:11, alokp wrote:
> third_party/angle: missing README.chromium
> 
> I added third_party/angle to SPECIAL_CASES. That should have fixed it. right?

Yes, I think so.  The other ones work, for example.

[alokp, 2010-04-29 20:29:06]

No it does not work for other ones in SPECIAL_CASES also.
third_party/angle: missing README.chromium
third_party/WebKit: missing README.chromium
third_party/ots: missing README.chromium

Is this how you run the tool?
python tools/licences.py scan

lgtm?

[Evan Martin, 2010-04-29 20:35:00]

I just run it as "./tools/licences.py scan".  Aha!  Maybe it's broken
on Windows?

This change LGTM then.  If you have a sec I'd love it if you figured
out why that doesn't work for you... the code is very simple, just
search for the error message to find where it's failing..

On Thu, Apr 29, 2010 at 1:29 PM,  <alokp@chromium.org> wrote:
> No it does not work for other ones in SPECIAL_CASES also.
> third_party/angle: missing README.chromium
> third_party/WebKit: missing README.chromium
> third_party/ots: missing README.chromium
>
> Is this how you run the tool?
> python tools/licences.py scan
>
> lgtm?
>
>
> http://codereview.chromium.org/1712014/show
>

[alokp, 2010-04-29 20:37:50]

Thanks Evan. Yes I am working on windows. I will look into it.