Issue 1712013: Fix bug in word-boundary-lookahead followed by end-of-input assertion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1712013: Fix bug in word-boundary-lookahead followed by end-of-input assertion. (Closed)

Created:
10 years, 8 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
sandholm, Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Fix bug in word-boundary-lookahead followed by end-of-input assertion.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added more tests #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -10 lines)			Patch
M	src/jsregexp.cc	View		1 chunk	+9 lines, -8 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/regexp.js	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 8 months ago (2010-04-26 14:39:40 UTC) #2

LGTM

http://codereview.chromium.org/1712013/diff/1/4
File test/mjsunit/regexp.js (right):

http://codereview.chromium.org/1712013/diff/1/4#newcode441
test/mjsunit/regexp.js:441: assertTrue(/b\b/.test("b"));
I'd like more tests!

How about /x\b/.test("xy");

Expand Messages | Collapse Messages