Issue 171114: Fixed cast in platform-macos.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171114: Fixed cast in platform-macos.cc (Closed)

Created:
11 years, 3 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

Fixed cast in platform-macos.cc TBR=whesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=2813

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/platform-macos.cc	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 3 months ago (2009-09-02 10:44:39 UTC) #2

LGTM, with comment.

http://codereview.chromium.org/171114/diff/1/2
File src/platform-macos.cc (right):

http://codereview.chromium.org/171114/diff/1/2#newcode212
Line 212: const mach_header* header = _dyld_get_image_header(i);
Could you move this variable into the #ifdef instead?  Is there a get_header
that returns a 64-bit header pointer?

Expand Messages | Collapse Messages