Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 171111: Create a set of x64 Visual studio project files and corresponding solution (Closed)

Created:
11 years, 4 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Create a set of x64 Visual studio project files and corresponding solution. These files will make it possible to start working with the 64-bit version on Windows. The GUID's of the x64 project files are the same as their ia32 counterparts, but that does not matter as they will never be used in the same solution. Added a temporary #error when building 64-bit version on Windows. Committed: http://code.google.com/p/v8/source/detail?r=2711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2441 lines, -2 lines) Patch
M src/platform-win32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/visual_studio/common.vsprops View 1 chunk +1 line, -1 line 0 comments Download
A tools/visual_studio/d8_x64.vcproj View 1 chunk +199 lines, -0 lines 0 comments Download
M tools/visual_studio/ia32.vsprops View 1 chunk +1 line, -1 line 0 comments Download
A tools/visual_studio/v8_base_x64.vcproj View 1 chunk +963 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_cctest_x64.vcproj View 1 chunk +251 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_mksnapshot_x64.vcproj View 1 chunk +151 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_process_sample_x64.vcproj View 1 chunk +151 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_shell_sample_x64.vcproj View 1 chunk +151 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_snapshot_cc_x64.vcproj View 1 chunk +92 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_snapshot_x64.vcproj View 1 chunk +142 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_x64.sln View 1 chunk +101 lines, -0 lines 0 comments Download
A tools/visual_studio/v8_x64.vcproj View 1 chunk +223 lines, -0 lines 0 comments Download
A tools/visual_studio/x64.vsprops View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 4 months ago (2009-08-18 15:20:15 UTC) #1
Lasse Reichstein
11 years, 4 months ago (2009-08-19 07:26:41 UTC) #2
LGTM (as much as I understand any of it)

Powered by Google App Engine
This is Rietveld 408576698