Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/debug.cc

Issue 171107: X64: Implement debugger hooks. (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.h ('k') | src/execution.h » ('j') | src/x64/assembler-x64-inl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 18536f5c7a9fe6cba3403d4cf98546db41c4143e..1eaba68aae8c3870a0c60e259fb192941cfb165b 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -1459,7 +1459,8 @@ void Debug::SetAfterBreakTarget(JavaScriptFrame* frame) {
RelocIterator it(debug_info->code());
while (!it.done()) {
if (RelocInfo::IsJSReturn(it.rinfo()->rmode())) {
- at_js_exit = it.rinfo()->pc() == addr - 1;
+ at_js_exit =
+ (it.rinfo()->pc() == addr - Assembler::kReturnAddrPatchPrefixSize);
}
it.next();
}
@@ -1478,7 +1479,8 @@ void Debug::SetAfterBreakTarget(JavaScriptFrame* frame) {
}
// Move one byte back to where the call instruction was placed.
Søren Thygesen Gjesse 2009/08/18 13:10:44 Comment out of sync with code.
Lasse Reichstein 2009/08/19 07:07:55 Fixed
- thread_local_.after_break_target_ = addr - 1;
+ thread_local_.after_break_target_ =
+ addr - Assembler::kReturnAddrPatchPrefixSize;
} else {
// Check if there still is a debug break call at the target address. If the
// break point has been removed it will have disappeared. If it have
« no previous file with comments | « src/debug.h ('k') | src/execution.h » ('j') | src/x64/assembler-x64-inl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698