X64: Implement debugger hooks.

src/debug.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1441 matching lines @@
   // Find the call address in the running code. This address holds the call to
   // either a DebugBreakXXX or to the debug break return entry code if the
   // break point is still active after processing the break point.
   Address addr = frame->pc() - Assembler::kTargetAddrToReturnAddrDist;
 
   // Check if the location is at JS exit.
   bool at_js_exit = false;
   RelocIterator it(debug_info->code());
   while (!it.done()) {
     if (RelocInfo::IsJSReturn(it.rinfo()->rmode())) {
-      at_js_exit = it.rinfo()->pc() == addr - 1;
+      at_js_exit =
+          (it.rinfo()->pc() == addr - Assembler::kReturnAddrPatchPrefixSize);
     }
     it.next();
   }
 
   // Handle the jump to continue execution after break point depending on the
   // break location.
   if (at_js_exit) {
     // First check if the call in the code is still the debug break return
     // entry code. If it is the break point is still active. If not the break
     // point was removed during break point processing.
     if (Assembler::target_address_at(addr) ==
         debug_break_return_entry()->entry()) {
       // Break point still active. Jump to the corresponding place in the
       // original code.
       addr +=  original_code->instruction_start() - code->instruction_start();
     }
 
     // Move one byte back to where the call instruction was placed.

[Søren Thygesen Gjesse, 2009/08/18 13:10:44]

Comment out of sync with code.

[Lasse Reichstein, 2009/08/19 07:07:55]

Fixed

-    thread_local_.after_break_target_ = addr - 1;
+    thread_local_.after_break_target_ =
+        addr - Assembler::kReturnAddrPatchPrefixSize;
   } else {
     // Check if there still is a debug break call at the target address. If the
     // break point has been removed it will have disappeared. If it have
     // disappeared don't try to look in the original code as the running code
     // will have the right address. This takes care of the case where the last
     // break point is removed from the function and therefore no "original code"
     // is available. If the debug break call is still there find the address in
     // the original code.
     if (IsDebugBreak(Assembler::target_address_at(addr))) {
       // If the break point is still there find the call address which was
@@ skipping 1071 matching lines @@
 
 
 void LockingCommandMessageQueue::Clear() {
   ScopedLock sl(lock_);
   queue_.Clear();
 }
 
 #endif  // ENABLE_DEBUGGER_SUPPORT
 
 } }  // namespace v8::internal