test_shell: allow relative paths on the command line

test_shell: allow relative paths on the command line

This makes "./out/Debug/test_shell path/to/file.html" do the right thing.
In theory I should use URLFixerUpper but that's deep inside chrome/browser/;
this is simple enough anyway.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45977

[Evan Martin, 2010-04-29 19:29:56]

darin: original code author
erg: more likely to review this quickly

Who will win in doing my review!

[Elliot Glaysher, 2010-04-29 19:54:39]

LGTM, but think about...

http://codereview.chromium.org/1711024/diff/1/2
File webkit/tools/test_shell/test_shell_main.cc (right):

http://codereview.chromium.org/1711024/diff/1/2#newcode229
webkit/tools/test_shell/test_shell_main.cc:229: file_util::AbsolutePath(&path);
Considering that you're doing this for convenience, you may want to check the
return value of file_util::AbsolutePath() and scream and die on failure.

[Evan Martin, 2010-04-29 20:12:04]

On 2010/04/29 19:54:39, Elliot Glaysher wrote:
> LGTM, but think about...
> 
> http://codereview.chromium.org/1711024/diff/1/2
> File webkit/tools/test_shell/test_shell_main.cc (right):
> 
> http://codereview.chromium.org/1711024/diff/1/2#newcode229
> webkit/tools/test_shell/test_shell_main.cc:229:
file_util::AbsolutePath(&path);
> Considering that you're doing this for convenience, you may want to check the
> return value of file_util::AbsolutePath() and scream and die on failure.

test_shell itself gives you a failure message in that case.  :)

[darin (slow to review), 2010-04-29 20:39:32]

LGTM2