Add a bind mount of /dev to the chroot.

Add a bind mount of /dev to the chroot.

This is useful for various JTAG and fastboot based flashing of
targets.  It is also useful in that we will now have access to
USB card readers and mass storage devices inside the chroot.

BUG=None
TEST=Enter and exit the chroot cleanly.

[robotboy, 2010-04-26 20:43:30]

I have been using this for a couple of weeks now, it seems to be working well
for me.  Please take a look.

Thanks,
    Anton

[adlr, 2010-04-26 20:45:44]

LGTM

On Mon, Apr 26, 2010 at 1:43 PM, <robotboy@chromium.org> wrote:

> Reviewers: tedbo, adlr, Antoine Labour,
>
> Message:
> I have been using this for a couple of weeks now, it seems to be working
> well
> for me.  Please take a look.
>
> Thanks,
>    Anton
>
> Description:
> Add a bind mount of /dev to the chroot.
>
> This is useful for various JTAG and fastboot based flashing of
> targets.  It is also useful in that we will now have access to
> USB card readers and mass storage devices inside the chroot.
>
> BUG=None
> TEST=Enter and exit the chroot cleanly.
>
> Please review this at http://codereview.chromium.org/1711016/show
>
> SVN Base: ssh://git@chromiumos-git/chromeos
>
> Affected files:
>  M src/scripts/enter_chroot.sh
>
>
> Index: src/scripts/enter_chroot.sh
> diff --git a/src/scripts/enter_chroot.sh b/src/scripts/enter_chroot.sh
> index
>
804d8ce64e16c4da7c15f4f710f8e2c294591ddb..77b4722897b03262132f4132e14c53b74ced4bab
> 100755
> --- a/src/scripts/enter_chroot.sh
> +++ b/src/scripts/enter_chroot.sh
> @@ -93,10 +93,10 @@ function setup_env {
>           die "Could not mount $MOUNTED_PATH"
>     fi
>
> -    MOUNTED_PATH="$(readlink -f "$FLAGS_chroot/dev/pts")"
> +    MOUNTED_PATH="$(readlink -f "${FLAGS_chroot}/dev")"
>     if [ -z "$(mount | grep -F "on $MOUNTED_PATH ")" ]
>     then
> -      sudo mount none -t devpts "$MOUNTED_PATH" || \
> +      sudo mount --bind /dev "$MOUNTED_PATH" || \
>           die "Could not mount $MOUNTED_PATH"
>     fi
>
> @@ -142,14 +142,8 @@ function setup_env {
>       fi
>     fi
>
> -    # Mount fuse device from host machine into chroot and copy over
> -    # corresponding kernel modules.
> -    MOUNTED_PATH="$(readlink -f "${FLAGS_chroot}${FUSE_DEVICE}")"
> -    if [ -z "$(mount | grep -F "on ${MOUNTED_PATH} ")" ] && \
> -      [ -c "${FUSE_DEVICE}" ] ; then
> -      echo "Attempting to mount fuse device for gmergefs"
> -      sudo touch "${MOUNTED_PATH}"
> -      sudo mount --bind "${FUSE_DEVICE}" "${MOUNTED_PATH}"
> +    # Install fuse module.
> +    if [ -c "${FUSE_DEVICE}" ] ; then
>       sudo modprobe fuse 2> /dev/null ||\
>         echo "-- Note: modprobe fuse failed.  gmergefs will not work"
>     fi
>
>
>

[piman, 2010-04-26 21:29:45]

LGTM