Issue 1711006: Sync: Delete and recreate the sync database if its corrupt....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1711006: Sync: Delete and recreate the sync database if its corrupt.... (Closed)

Created:
10 years, 8 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
albertb

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sync: Delete and recreate the sync database if its corrupt. BUG=40020 TEST=See bug.

Patch Set 1 #

Created: 10 years, 8 months ago

		Unified diffs	Side-by-side diffs	Stats (+13 lines, -3 lines)
	M	chrome/browser/sync/syncable/directory_backing_store.cc	View	4 chunks	+13 lines, -3 lines	0 comments

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

albertb

10 years, 8 months ago (2010-04-21 19:00:49 UTC) #1

Hi Lei,

This patch looks promising and does take care of the crashing PRAGMA statement
in release mode. I wrote some unit tests for it and although I understand why
(dozens of DCHECKs), I find it a little weird that debug builds still crash...

I'll look for ways to detect earlier whether the database is corrupted and see
if I can make debug builds work too.

Expand Messages | Collapse Messages