Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 171093: Omit DLOGs and DCHECKs from release-mode Google Chrome-branded builds (Closed)

Created:
11 years, 4 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Omit DLOGs and DCHECKs from release-mode Google Chrome-branded builds on non-Windows. They were previously omitted on Windows official builds only. BUG=16512 TEST=DCHECK logging unavailable in official builds; Mac .app shrinks by about 740kB; Mac .dmg shrinks by about 315kB; Linux binary and package shrink by similar amounts Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23791

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M base/logging.h View 1 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
We tried this before at r20497 but reverted it at r20889 because it caused hangs. ...
11 years, 4 months ago (2009-08-18 02:03:05 UTC) #1
Mark Mentovai
We're hanging in IPCSyncChannelTest.ChattyServer when the DCHECK_EQ in LockImpl::Lock, base/lock_impl_posix.cc, is optimized away.
11 years, 4 months ago (2009-08-18 04:14:58 UTC) #2
Mark Mentovai
This depends on http://codereview.chromium.org/173059 and http://crbug.com/19710. Other than that, it's ready to go.
11 years, 4 months ago (2009-08-19 16:23:56 UTC) #3
TVL
11 years, 4 months ago (2009-08-19 16:28:47 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698