Issue 171042: Added API call to get the stack trace for an exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171042: Added API call to get the stack trace for an exception (Closed)

Created:
11 years, 4 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Added API call to get the stack trace for an exception Added TryCatch::StackTrace that gets the stack trace for the thrown exception.

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -0 lines)
M	include/v8.h	View	1 chunk	+6 lines, -0 lines	0 comments
M	src/api.cc	View	1 chunk	+17 lines, -0 lines	2 comments
M	test/cctest/test-api.cc	View	1 chunk	+13 lines, -0 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/171042/diff/1/3 File src/api.cc (right): http://codereview.chromium.org/171042/diff/1/3#newcode1227 Line 1227: i::Handle<i::Object> raw_obj(raw_ptr); Why not just i::Handle<i::JSObject> obj(i::JSObject::cast(raw_ptr));

11 years, 4 months ago (2009-08-17 13:30:16 UTC) #2

Christian Plesner Hansen

11 years, 4 months ago (2009-08-17 13:33:59 UTC) #3

http://codereview.chromium.org/171042/diff/1/3
File src/api.cc (right):

http://codereview.chromium.org/171042/diff/1/3#newcode1227
Line 1227: i::Handle<i::Object> raw_obj(raw_ptr);
Done

Expand Messages | Collapse Messages