Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 171041: Use root array to load roots in generated ARM code.... (Closed)

Created:
11 years, 4 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Use root array to load roots in generated ARM code. This cuts down on code size and reloc work. Committed: http://code.google.com/p/v8/source/detail?r=2701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -109 lines) Patch
M src/arm/builtins-arm.cc View 6 chunks +12 lines, -8 lines 0 comments Download
M src/arm/cfg-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 31 chunks +64 lines, -41 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/ic-arm.cc View 6 chunks +14 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 5 chunks +16 lines, -5 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M src/arm/virtual-frame-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap.h View 3 chunks +23 lines, -20 lines 0 comments Download
M src/serialize.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 4 months ago (2009-08-17 12:04:18 UTC) #1
William Hesse
11 years, 4 months ago (2009-08-17 13:02:09 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698