Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: build/mac/tweak_app_infoplist

Issue 171040: add the InfoPlist.strings generation based on GRD strings.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/app-Info.plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/tweak_app_infoplist
===================================================================
--- build/mac/tweak_app_infoplist (revision 24091)
+++ build/mac/tweak_app_infoplist (working copy)
@@ -62,11 +62,9 @@
TOP="${SRCROOT}/.."
BUILD_BRANDING=$1
-BRAND_SCRIPT="${TOP}/build/branding_value.sh"
set -x
-APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME)
SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}"
if [ "${USE_SVN}" = "1" ] ; then
@@ -103,14 +101,6 @@
. "${TOP}/chrome/VERSION"
FULL_VERSION="${MAJOR}.${MINOR}.${BUILD}.${PATCH}"
-# Fetch the copyright.
-COPYRIGHT_STRING=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" COPYRIGHT)
-# Map (c) or (C) to the copyright symbol.
-COPYRIGHT_STRING=$(echo "${COPYRIGHT_STRING}" | sed -e $'s/([cC])/\302\251/g')
-
-# Build the full copyright string
-LONG_COPYRIGHT="${APP_NAME} ${FULL_VERSION}, ${COPYRIGHT_STRING}"
-
# I really hate how "defaults" doesn't take a real pathname but instead insists
# on appending ".plist" to everything.
INFO_PLIST_PATH="Contents/Info.plist"
@@ -134,8 +124,6 @@
# Add public version info so "Get Info" works
defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
- CFBundleGetInfoString -string "${LONG_COPYRIGHT}"
-defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
CFBundleShortVersionString -string "${FULL_VERSION}"
# Honor the 429496.72.95 limit. The maximum comes from splitting 2^32 - 1 into
# 6, 2, 2 digits. The limitation was present in Tiger, but it could have been
@@ -146,8 +134,6 @@
# unique that meetings what LS wants.
defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
CFBundleVersion -string "${BUILD}.${PATCH}"
-defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
- NSHumanReadableCopyright -string "${COPYRIGHT_STRING}"
# Add or remove the Breakpad keys.
if [ "${USE_BREAKPAD}" = "1" ] ; then
« no previous file with comments | « no previous file | chrome/app/app-Info.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698