Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 171039: RegExp tweaks (Closed)

Created:
11 years, 4 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

RegExp tweaks Fixed bug where regexps were not callable across contexts since the callable test used object identity on the regexp constructor. Changed typeof RegExp from 'object' to 'function' for compatibility.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/execution.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
11 years, 4 months ago (2009-08-17 10:14:11 UTC) #1
Mads Ager (chromium)
11 years, 4 months ago (2009-08-17 10:16:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698