Issue 171038: Fix issue 420: accept truncated log files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171038: Fix issue 420: accept truncated log files. (Closed)

Created:
11 years, 4 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Fix issue 420: accept truncated log files. http://code.google.com/p/v8/issues/detail?id=420 Committed: http://code.google.com/p/v8/source/detail?r=2695

Patch Set 2 : Comment addressed #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -4 lines)			Patch
M	test/mjsunit/mjsunit.js	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	test/mjsunit/tools/logreader.js	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	tools/logreader.js	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/171038/diff/1/3 File test/mjsunit/tools/logreader.js (right): http://codereview.chromium.org/171038/diff/1/3#newcode85 Line 85: (function testIssue420() { Please call this function ...

11 years, 4 months ago (2009-08-17 09:25:18 UTC) #2

mnaganov (inactive)

11 years, 4 months ago (2009-08-17 09:31:35 UTC) #3

http://codereview.chromium.org/171038/diff/1/3
File test/mjsunit/tools/logreader.js (right):

http://codereview.chromium.org/171038/diff/1/3#newcode85
Line 85: (function testIssue420() {
On 2009/08/17 09:25:19, Søren Gjesse wrote:
> Please call this function something like testTruncatedLog. Alternatively add a
> regress sub-directory with the file regress-420.js.

OK. Renamed and added a link to an issue.

Expand Messages | Collapse Messages

Issue 171038: Fix issue 420: accept truncated log files. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comment addressed #

Messages