Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 171012: Use 'icu::' namespace explicitly (Closed)

Created:
11 years, 4 months ago by jungshik at Google
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium
Visibility:
Public.

Description

Use 'icu::' namespace explicitly throughout Chrome tree instead of relying on 'using namespace icu'. This is Chrome's counterpart to the ICU header change that disables 'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece. The webkit change (which is minor) will be dealt with in the webkit bugzilla. This can go in before the ICU change/upgrade without affecting anything. BUG=8198 TEST=All the targets are built without an error on all platforms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23613

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -123 lines) Patch
M app/gfx/text_elider.h View 2 3 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/text_elider.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/text_elider_unittest.cc View 2 3 1 chunk +2 lines, -1 line 0 comments Download
M app/l10n_util.h View 1 2 3 7 chunks +9 lines, -9 lines 0 comments Download
M app/l10n_util.cc View 2 3 6 chunks +13 lines, -12 lines 0 comments Download
M app/l10n_util_unittest.cc View 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M app/table_model.h View 2 3 1 chunk +1 line, -1 line 0 comments Download
M app/table_model.cc View 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M base/file_util_icu.cc View 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M base/file_util_posix.cc View 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M base/string_util_icu.cc View 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M base/time_format.cc View 2 3 2 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/snippet.cc View 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellcheck_worditerator.cc View 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/task_manager.cc View 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/time_format.cc View 2 3 5 chunks +25 lines, -27 lines 0 comments Download
M net/base/net_util.cc View 1 2 3 4 8 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
I'll also send an email to chromium-dev to announce that C++ names of ICU must ...
11 years, 4 months ago (2009-08-15 08:28:14 UTC) #1
darin (slow to review)
LGTM
11 years, 4 months ago (2009-08-16 18:58:18 UTC) #2
Mark Mentovai
http://codereview.chromium.org/171012/diff/54/1012 File net/base/net_util.cc (right): http://codereview.chromium.org/171012/diff/54/1012#newcode592 Line 592: "[[\\u0020\\u00bc\\u00bd\\u01c3\\u0337\\u0338" You're losing "\\ " from the set ...
11 years, 4 months ago (2009-08-16 19:48:31 UTC) #3
jungshik at Google
11 years, 4 months ago (2009-08-17 04:08:40 UTC) #4
http://codereview.chromium.org/171012/diff/54/1012
File net/base/net_util.cc (right):

http://codereview.chromium.org/171012/diff/54/1012#newcode592
Line 592: "[[\\u0020\\u00bc\\u00bd\\u01c3\\u0337\\u0338"
On 2009/08/16 19:48:31, Mark Mentovai wrote:
> You're losing "\\ " from the set here.  Intentional?

I didn't mean to include this part in the CL, but it seems harmless.

Anyway, '\\ ' is to represent 'SPACE' (U+0020). '\\ ' is turned to '\ ' in
memory and passed to UnicodeSet ctor, which does its own string escaping to get
' ' (U+0020).  Yeah, it's confusing. 

 The previous code is a bit fishy with '\uXXXX' although it worked (otherwise,
unittest would have failed). 

 To avoid the confusion,  '\\u0020' is used in its place.

Powered by Google App Engine
This is Rietveld 408576698