Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1709010: Honor the select_all argument to AutocompleteEditViewMac::FocusLocation (Closed)

Created:
10 years, 8 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, Peter Kasting
Visibility:
Public.

Description

Honor the select_all argument to AutocompleteEditViewMac::FocusLocation. Calling -[NSWindow makeFirstResponder:] to give focus to the AutocompleteTextField will select the entire contents of the field. If the field is already focused and "select all" is not desired, avoid making this call. If "select all" is desired, or if the field is not focused (regardless of the value of select_all), the field will be focused and its entire contents selected. BUG=40322, 40682 TEST=With a profile primed so that "google.com" is the first suggestion when typing "g" in the location bar, and no windows open, quickly press command-N and begin typing "google" while the tab is being created. Expect all of the entered characters to make it to the location bar. When the bug occurs, the location bar in its entirety will be selected at some point during or immediately following tab creation, which will cause previously-typed text to be lost or the first autocomplete suggestion to be chosen, and something like "ogle" or "google.com/ogle" to appear in the location bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
10 years, 8 months ago (2010-04-26 21:54:11 UTC) #1
Scott Hess - ex-Googler
10 years, 8 months ago (2010-04-26 22:25:17 UTC) #2
LGTM.

Hope it fixes it!

Powered by Google App Engine
This is Rietveld 408576698