Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/path_service.cc

Issue 1709: CreateDirectory() should check if an existing path is actually a directory... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util_win.cc ('k') | net/disk_cache/backend_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/path_service.cc
===================================================================
--- base/path_service.cc (revision 2057)
+++ base/path_service.cc (working copy)
@@ -205,9 +205,7 @@
return false;
// make sure the directory exists:
- if (!file_util::PathExists(file_path) &&
- // TODO(darin): what if this path is not that of a directory?
- !file_util::CreateDirectory(file_path))
+ if (!file_util::CreateDirectory(file_path))
return false;
file_util::TrimTrailingSeparator(&file_path);
@@ -251,4 +249,3 @@
#endif
path_data->providers = p;
}
-
« no previous file with comments | « base/file_util_win.cc ('k') | net/disk_cache/backend_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698