CreateDirectory() should check if an existing path is actually a directory...

base/path_service.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 
 #ifdef OS_WIN
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
@@ skipping 187 matching lines @@
 bool PathService::Override(int key, const std::wstring& path) {
   PathData* path_data = GetPathData();
   DCHECK(path_data);
   DCHECK(key > base::DIR_CURRENT) << "invalid path key";
 
   std::wstring file_path = path;
   if (!file_util::AbsolutePath(&file_path))
     return false;
 
   // make sure the directory exists:
-  if (!file_util::PathExists(file_path) &&
-      // TODO(darin): what if this path is not that of a directory?
-      !file_util::CreateDirectory(file_path))
+  if (!file_util::CreateDirectory(file_path))
     return false;
 
   file_util::TrimTrailingSeparator(&file_path);
 
   AutoLock scoped_lock(path_data->lock);
   path_data->cache[key] = file_path;
   path_data->overrides.insert(key);
   return true;
 }
 
@@ skipping 23 matching lines @@
   p = new Provider;
   p->is_static = false;
   p->func = func;
   p->next = path_data->providers;
 #ifndef NDEBUG
   p->key_start = key_start;
   p->key_end = key_end;
 #endif
   path_data->providers = p;
 }
-