CreateDirectory() should check if an existing path is actually a directory...

base/file_util_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
 #include <time.h>
@@ skipping 158 matching lines @@
                  FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,
                  NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, NULL);
 
   if (dir == INVALID_HANDLE_VALUE)
     return false;
 
   CloseHandle(dir);
   return true;
 }
 
+bool DirectoryExists(const std::wstring& path) {
+  DWORD fileattr = GetFileAttributes(path.c_str());
+  if (fileattr != INVALID_FILE_ATTRIBUTES)
+    return (fileattr & FILE_ATTRIBUTE_DIRECTORY) != 0;
+  return false;
+}
+
 bool GetFileCreationLocalTimeFromHandle(HANDLE file_handle,
                                         LPSYSTEMTIME creation_time) {
   if (!file_handle)
     return false;
 
   FILETIME utc_filetime;
   if (!GetFileTime(file_handle, &utc_filetime, NULL, NULL))
     return false;
 
   FILETIME local_filetime;
@@ skipping 223 matching lines @@
 
   if (count == 50) {
     return false;
   }
 
   new_temp_path->assign(path_to_create);
   return true;
 }
 
 bool CreateDirectory(const std::wstring& full_path) {
-  if (PathExists(full_path))
+  if (DirectoryExists(full_path))
     return true;
   int err = SHCreateDirectoryEx(NULL, full_path.c_str(), NULL);
   return err == ERROR_SUCCESS;
 }
 
 bool GetFileSize(const std::wstring& file_path, int64* file_size) {
   ScopedHandle file_handle(
       CreateFile(file_path.c_str(), GENERIC_READ,
                  FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL,
                  OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL));
@@ skipping 205 matching lines @@
       return (file_type_ & FileEnumerator::DIRECTORIES) ? cur_file : Next();
     }
 
     if ((file_type_ & FileEnumerator::DIRECTORIES) == 0)
       return Next();
   }
   return (file_type_ & FileEnumerator::FILES) ? cur_file : Next();
 }
 
 }  // namespace file_util