Issue 1708015: Use customized RGBA-enabled tooltip window for tooltip on ChroemOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1708015: Use customized RGBA-enabled tooltip window for tooltip on ChroemOS (Closed)

Created:
10 years, 8 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Use customized RGBA-enabled tooltip window for tooltip on ChroemOS - Add a TooltipWindowGtk which uses RGBA colormap and has a label; - Use TooltipWindowGtk for tooltip for both WidgetGtk and RenderWidgetHostViewGtk After this change, we will get back shadow and rounded corner for tooltip in theme engine. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45854

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix the nit #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -66 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_gtk.h	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View		4 chunks	+17 lines, -0 lines	0 comments	Download
M	views/views.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/widget/tooltip_manager_gtk.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	views/widget/tooltip_manager_gtk.cc	View		3 chunks	+3 lines, -64 lines	0 comments	Download
A	views/widget/tooltip_window_gtk.h	View		1 chunk	+52 lines, -0 lines	0 comments	Download
A	views/widget/tooltip_window_gtk.cc	View		1 chunk	+94 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM Glad to see GTK fixed the bug that prevented this from working in the ...

10 years, 8 months ago (2010-04-28 18:41:37 UTC) #2

xiyuan

10 years, 8 months ago (2010-04-28 18:54:38 UTC) #3

http://codereview.chromium.org/1708015/diff/1/3
File chrome/browser/renderer_host/render_widget_host_view_gtk.h (right):

http://codereview.chromium.org/1708015/diff/1/3#newcode32
chrome/browser/renderer_host/render_widget_host_view_gtk.h:32: };
On 2010/04/28 18:41:37, sky wrote:
> nit: no ; here

Done. I don't know why I keep making this mistake. :p

Expand Messages | Collapse Messages