Issue 1708011: Disable QueuedSharedWorkerShutdown because it's turned super flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1708011: Disable QueuedSharedWorkerShutdown because it's turned super flaky. (Closed)

Created:
10 years, 8 months ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
Andrew T Wilson (Slow), Paweł Hajdan Jr.

CC:
chromium-reviews, jam

Visibility:
Public.

Description

Disable QueuedSharedWorkerShutdown because it's turned super flaky. TEST=none BUG=42641 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45715

Patch Set 1 #

Patch Set 2 : delete tabs #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	chrome/worker/worker_uitest.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Drive-by. If it doesn't crash or hang the entire ui_tests, could you use FLAKY_ rather ...

10 years, 8 months ago (2010-04-27 18:55:31 UTC) #2

jorlow

10 years, 8 months ago (2010-04-28 13:16:53 UTC) #3

I didn't know this was the preferred convention.  Should the "FLAKY_" label
be changed to something else?  And maybe there should be a mail to
chromium-dev about doing this?  Sounds like a good idea tho.

On Tue, Apr 27, 2010 at 7:55 PM, <phajdan.jr@chromium.org> wrote:

> Drive-by.
>
> If it doesn't crash or hang the entire ui_tests, could you use FLAKY_
> rather
> than DISABLED_ ? This way we will continue to get valuable data from the
> flakiness dashboard.
>
>
> http://codereview.chromium.org/1708011/show
>

Expand Messages | Collapse Messages