Issue 1708009: Fix case where backup socket jobs ignored the socket limits....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1708009: Fix case where backup socket jobs ignored the socket limits.... (Closed)

Created:
10 years, 8 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix case where backup socket jobs ignored the socket limits. Add some logging when socket limits are reached. BUG=42597 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45722

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	net/socket/client_socket_pool_base.cc	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

10 years, 8 months ago (2010-04-27 00:54:21 UTC) #2

We should really have a test for this bug to prevent a regression.  LGTM
otherwise.

http://codereview.chromium.org/1708009/diff/1/2
File net/socket/client_socket_pool_base.cc (right):

http://codereview.chromium.org/1708009/diff/1/2#newcode304
net/socket/client_socket_pool_base.cc:304: if (ReachedMaxSocketsLimit() ||
The other limit you should check is to see if the group has an available socket
slot (we shouldn't exceed the 6 sockets per group limit).

Expand Messages | Collapse Messages