Issue 1708006: add ENABLE_GLES flag for conditional complilation of GLES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1708006: add ENABLE_GLES flag for conditional complilation of GLES (Closed)

Created:
10 years, 8 months ago by wjia(left Chromium)

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

add ENABLE_GLES flag for conditional complilation of GLES related code Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45635

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	build/common.gypi	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

Will this change put restriction on building chrome outside chroot with chromeos=1, arm=1 and linux=1? ...

10 years, 8 months ago (2010-04-26 21:09:51 UTC) #5

piman

10 years, 8 months ago (2010-04-26 21:13:07 UTC) #6

On Mon, Apr 26, 2010 at 2:09 PM, <wjia@chromium.org> wrote:

> Will this change put restriction on building chrome outside chroot with
> chromeos=1, arm=1 and linux=1? Or that build mode is not allowed?
>
> Wei

This change as is doesn't do anything - until you start using the
ENABLE_GLES define.

When building outside the chroot, it'll still work provided you use a
chromeos sysroot that has the GLES headers.

Antoine

>
> On 2010/04/25 22:49:29, piman wrote:
>
>> LGTM
>>
>
>
>
> http://codereview.chromium.org/1708006/show
>

Expand Messages | Collapse Messages