Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1706021: Merge 58616 - WebCore: Convert m_documentUnderMouse, m_dragInitiator to RefPt... (Closed)

Created:
10 years, 7 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 58616 - WebCore: Convert m_documentUnderMouse, m_dragInitiator to RefPtr. Eliminated unused m_dragInitiator accessor to prevent dereferencing. https://bugs.webkit.org/show_bug.cgi?id=37618 BUG=41469 TEST=drag-drop-iframe-refresh-crash.html Patch by Abhishek Arya <inferno@chromium.org>; on 20100430 Reviewed by David Kilzer. Test: editing/pasteboard/dragdropiframerefreshcrash.html * page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::concludeEditDrag): * page/DragController.h: (WebCore::DragController::draggingImageURL): (WebCore::DragController::documentUnderMouse): LayoutTests: Tests for a crash when an image dragdrop operation happens inside a continuously refreshing iframe. https://bugs.webkit.org/show_bug.cgi?id=37618 Patch by Abhishek Arya <inferno@chromium.org>; on 20100430 Reviewed by David Kilzer. * editing/pasteboard/dragdropiframerefreshcrashexpected.txt: Added. * editing/pasteboard/dragdropiframerefreshcrash.html: Added. * editing/resources/dragdrop.html: Added. * platform/qt/Skipped: TBR=ddkilzer@apple.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -9 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/editing/pasteboard/drag-drop-iframe-refresh-crash.html View 1 chunk +58 lines, -0 lines 0 comments Download
A LayoutTests/editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/editing/resources/drag-drop.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/qt/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +17 lines, -0 lines 0 comments Download
M WebCore/page/DragController.h View 2 chunks +3 lines, -5 lines 0 comments Download
M WebCore/page/DragController.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 7 months ago (2010-05-01 16:34:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698