src/arm/stub-cache-arm.cc - Issue 1706013: Changing string length field type from int to SMI. It will make it be a regu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/stub-cache-arm.cc

Issue 1706013: Changing string length field type from int to SMI. It will make it be a regu... (Closed) Base URL: http://v8.googlecode.com/svn/trunk/

Patch Set: '' Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/stub-cache-arm.cc

===================================================================

--- src/arm/stub-cache-arm.cc (revision 4579)

+++ src/arm/stub-cache-arm.cc (working copy)

@@ -229,7 +229,6 @@

// Load length directly from the string.

__ ldr(r0, FieldMemOperand(receiver, String::kLengthOffset));

- __ mov(r0, Operand(r0, LSL, kSmiTagSize));

__ Ret();

// Check if the object is a JSValue wrapper.

@@ -241,7 +240,6 @@

__ ldr(scratch1, FieldMemOperand(receiver, JSValue::kValueOffset));

GenerateStringCheck(masm, scratch1, scratch2, scratch2, miss, miss);

__ ldr(r0, FieldMemOperand(scratch1, String::kLengthOffset));

- __ mov(r0, Operand(r0, LSL, kSmiTagSize));

__ Ret();

}

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »