src/ia32/stub-cache-ia32.cc - Issue 1706013: Changing string length field type from int to SMI. It will make it be a regu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 1706013: Changing string length field type from int to SMI. It will make it be a regu... (Closed) Base URL: http://v8.googlecode.com/svn/trunk/

Patch Set: '' Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

===================================================================

--- src/ia32/stub-cache-ia32.cc (revision 4579)

+++ src/ia32/stub-cache-ia32.cc (working copy)

@@ -221,7 +221,6 @@

// Load length from the string and convert to a smi.

__ mov(eax, FieldOperand(receiver, String::kLengthOffset));

- __ SmiTag(eax);

__ ret(0);

// Check if the object is a JSValue wrapper.

@@ -234,7 +233,6 @@

__ mov(scratch2, FieldOperand(receiver, JSValue::kValueOffset));

GenerateStringCheck(masm, scratch2, scratch1, miss, miss);

__ mov(eax, FieldOperand(scratch2, String::kLengthOffset));

- __ SmiTag(eax);

__ ret(0);

}

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »