Issue 1705023: Cleans up image_to_live changes and handles errors more gracefully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1705023: Cleans up image_to_live changes and handles errors more gracefully (Closed)

Created:
10 years, 7 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

Cleans up image_to_live changes and handles errors more gracefully TEST=Tested by running image_to_live with correct formated images as well as images that are missing either /var or dev_image directories.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixes #

Patch Set 3 : Fix english #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -13 lines)			Patch
	M	src/scripts/image_to_live.sh	View	1 2	3 chunks	+26 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM - looking forward to this landing - missing image_to_live. http://codereview.chromium.org/1705023/diff/1/2 File src/scripts/image_to_live.sh (right): http://codereview.chromium.org/1705023/diff/1/2#newcode71 ...

10 years, 7 months ago (2010-04-30 19:10:24 UTC) #2

sosa

10 years, 7 months ago (2010-04-30 19:41:36 UTC) #3

Fixes in.  Pushing.

http://codereview.chromium.org/1705023/diff/1/2
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/1705023/diff/1/2#newcode71
src/scripts/image_to_live.sh:71: pushd /tmp/s/var && sudo tar -cf /tmp/var.tar .
&& popd
On 2010/04/30 19:10:24, kmixter1 wrote:
> why not gz?

Done.

http://codereview.chromium.org/1705023/diff/1/2#newcode77
src/scripts/image_to_live.sh:77: remote_sh "rm -rf $s_dir/var_new
$s_dir/dev_image_new &&\
On 2010/04/30 19:10:24, kmixter1 wrote:
> Are the trailing \'s necessary?

Yes since it's all part of the same string.  I could separate to many
remote_sh's but I'm following the style from prepare_update_metadata

http://codereview.chromium.org/1705023/diff/1/2#newcode81
src/scripts/image_to_live.sh:81: touch $s_dir/.update_available"
On 2010/04/30 19:10:24, kmixter1 wrote:
> Maybe comment who's on the other side of this - aka what does the final
> rename/mv?

Done.

Expand Messages | Collapse Messages