Changing linux platform for chromeos.

Changing linux platform for chromeos.  This involved moving platform_util and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45986

[dhg, 2010-04-27 21:16:03]

not 100% thrilled with this implementation, but lemme know if you have
suggestions.  I keep on going, should this be someplace else, but this is where
it really makes sense i think...

[zel, 2010-04-27 21:49:50]

this is too #ifdefy for my taste. i would rather split chromeos specific stuff
into its own file

[dhg, 2010-04-27 22:01:19]

I thought about htat, but there's a bunch of magic in the make files
that actually looks for _linux and includes them or not. (same with
win and the like)  Seemed like the change necessary to change that (if
possible) was worse than this if def mess.

On Tue, Apr 27, 2010 at 2:49 PM,  <zelidrag@chromium.org> wrote:
> this is too #ifdefy for my taste. i would rather split chromeos specific
> stuff
> into its own file
>
> http://codereview.chromium.org/1705009/show
>



-- 
David Garcia
---------------------
I'm participating in Team In Training!  Check it out:
http://pages.teamintraining.org/sj/AveGiant10/dgarciaijk

[zel, 2010-04-27 22:05:28]

You can always explicitly exclude/include certain files for a given platform
as well. We have been doing that with number of files already.

On Tue, Apr 27, 2010 at 3:01 PM, David Garcia <dhg@chromium.org> wrote:

> I thought about htat, but there's a bunch of magic in the make files
> that actually looks for _linux and includes them or not. (same with
> win and the like)  Seemed like the change necessary to change that (if
> possible) was worse than this if def mess.
>
> On Tue, Apr 27, 2010 at 2:49 PM,  <zelidrag@chromium.org> wrote:
> > this is too #ifdefy for my taste. i would rather split chromeos specific
> > stuff
> > into its own file
> >
> > http://codereview.chromium.org/1705009/show
> >
>
>
>
> --
> David Garcia
> ---------------------
> I'm participating in Team In Training!  Check it out:
> http://pages.teamintraining.org/sj/AveGiant10/dgarciaijk
>

[dhg, 2010-04-28 17:21:08]

seperated out.  I can't get the try bots to run tho...

On 2010/04/27 22:05:28, zel wrote:
> You can always explicitly exclude/include certain files for a given platform
> as well. We have been doing that with number of files already.
> 
> On Tue, Apr 27, 2010 at 3:01 PM, David Garcia <mailto:dhg@chromium.org> wrote:
> 
> > I thought about htat, but there's a bunch of magic in the make files
> > that actually looks for _linux and includes them or not. (same with
> > win and the like)  Seemed like the change necessary to change that (if
> > possible) was worse than this if def mess.
> >
> > On Tue, Apr 27, 2010 at 2:49 PM,  <mailto:zelidrag@chromium.org> wrote:
> > > this is too #ifdefy for my taste. i would rather split chromeos specific
> > > stuff
> > > into its own file
> > >
> > > http://codereview.chromium.org/1705009/show
> > >
> >
> >
> >
> > --
> > David Garcia
> > ---------------------
> > I'm participating in Team In Training!  Check it out:
> > http://pages.teamintraining.org/sj/AveGiant10/dgarciaijk
> >
>

[dhg, 2010-04-29 18:27:10]

OK, this CL grew a lot.  Most of these file changes are involved with the moving
of extension_error_reporter.h/cc to browser, and the moving of platform_util to
browser.  So most are just .h location changes.

I think its good now tho.
On 2010/04/28 17:21:08, dhg wrote:
> seperated out.  I can't get the try bots to run tho...
> 
> On 2010/04/27 22:05:28, zel wrote:
> > You can always explicitly exclude/include certain files for a given platform
> > as well. We have been doing that with number of files already.
> > 
> > On Tue, Apr 27, 2010 at 3:01 PM, David Garcia <mailto:dhg@chromium.org>
wrote:
> > 
> > > I thought about htat, but there's a bunch of magic in the make files
> > > that actually looks for _linux and includes them or not. (same with
> > > win and the like)  Seemed like the change necessary to change that (if
> > > possible) was worse than this if def mess.
> > >
> > > On Tue, Apr 27, 2010 at 2:49 PM,  <mailto:zelidrag@chromium.org> wrote:
> > > > this is too #ifdefy for my taste. i would rather split chromeos specific
> > > > stuff
> > > > into its own file
> > > >
> > > > http://codereview.chromium.org/1705009/show
> > > >
> > >
> > >
> > >
> > > --
> > > David Garcia
> > > ---------------------
> > > I'm participating in Team In Training!  Check it out:
> > > http://pages.teamintraining.org/sj/AveGiant10/dgarciaijk
> > >
> >

[zel, 2010-04-29 19:41:21]

LGTM

[M-A Ruel, 2010-12-13 15:52:54]

http://codereview.chromium.org/1705009/diff/17005/chrome/browser/platform_uti...
File chrome/browser/platform_util_chromeos.cc (right):

http://codereview.chromium.org/1705009/diff/17005/chrome/browser/platform_uti...
chrome/browser/platform_util_chromeos.cc:46: if (ext == ".jpg" ||
Could you create a global constant array instead?

Also it misses frequent extensions like '.jpe' here and '.divx', '.mp2', '.wav'
and whatever god knows for the check around line 68. I'm not sure about mp2
support but mp3 inside a .wav container are also frequent enough. There should
probably be a code path for .swf and .pdf. Content sniffing would probably be a
good idea, if possible.