Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 17050: Update Channel Changer to support a new Dev channel tag.... (Closed)

Created:
11 years, 11 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update Channel Changer to support a new Dev channel tag. I want to declare 1.1-dev users "on the Beta channel" and create a new 2.0-dev tag for the Dev channel. To do that I needed to make the Channel Changer recognize 1.1-dev as Beta. I also changed some strings: * make the note about changing to a more stable channel a little clearer * make the dialog title 'Channel Changer' (instead of Switcher) The vcproj needed to be updated for the Release rule. (Jungshik changed Debug in r7532.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7559

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M tools/channel_changer/channel_changer.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M tools/channel_changer/channel_changer.rc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/channel_changer/channel_changer.vcproj View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Larson
11 years, 11 months ago (2009-01-04 01:58:56 UTC) #1
Finnur
http://codereview.chromium.org/17050/diff/1/4 File tools/channel_changer/channel_changer.cc (right): http://codereview.chromium.org/17050/diff/1/4#newcode114 Line 114: // just declare the user on the Beta ...
11 years, 11 months ago (2009-01-05 18:07:16 UTC) #2
Mark Larson
http://codereview.chromium.org/17050/diff/1/4 File tools/channel_changer/channel_changer.cc (right): http://codereview.chromium.org/17050/diff/1/4#newcode114 Line 114: // just declare the user on the Beta ...
11 years, 11 months ago (2009-01-05 19:35:32 UTC) #3
Finnur
In that case: LGTM (with one nit that was missing from last email) http://codereview.chromium.org/17050/diff/1/4 File ...
11 years, 11 months ago (2009-01-05 20:11:13 UTC) #4
Mark Larson
11 years, 11 months ago (2009-01-05 20:56:23 UTC) #5
I fixed the braces and submitted as r7559.

http://codereview.chromium.org/17050/diff/1/4
File tools/channel_changer/channel_changer.cc (right):

http://codereview.chromium.org/17050/diff/1/4#newcode117
Line 117: }
On 2009/01/05 20:11:13, Finnur wrote:
> Hmm... It looks like Rietveld ate one of my comments here:
> This is a single line if clause so you don't need the braces.

Braces removed.

> 
> On 2009/01/05 19:35:32, Mark Larson (Google) wrote:
> > On 2009/01/05 18:07:16, Finnur wrote:
> > > However, I suspect you want more than this, since it looks to me like you
> are
> > > deprecating the OLD_DEV_BRANCH. This won't change the branch from
> > OLD_DEV_BRANCH
> > > to BETA_BRANCH (unless the user hits Save, in which case it will write
that
> > > value to the registry). Is this what you want?
> > 
> > Yes, that's what I want. It seems the simplest solution. 1.1-dev will get
> > treated as 'beta' by the update rules, so there's no need to jump through
> hoops
> > to try to change the registry value to 1.1-beta.
> > 
> > 
> 
>

Powered by Google App Engine
This is Rietveld 408576698