Update Channel Changer to support a new Dev channel tag....

Update Channel Changer to support a new Dev channel tag.

I want to declare 1.1-dev users "on the Beta channel" and
create a new 2.0-dev tag for the Dev channel. To do that 
I needed to make the Channel Changer recognize 1.1-dev as
Beta.

I also changed some strings:

  * make the note about changing to a more stable channel 
    a little clearer
  * make the dialog title 'Channel Changer' (instead of 
    Switcher)

The vcproj needed to be updated for the Release rule. 
(Jungshik changed Debug in r7532.)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7559

[Finnur, 2009-01-05 18:07:16]

http://codereview.chromium.org/17050/diff/1/4
File tools/channel_changer/channel_changer.cc (right):

http://codereview.chromium.org/17050/diff/1/4#newcode114
Line 114: // just declare the user on the Beta channel.
You have trailing whitespaces at the end of these lines.

http://codereview.chromium.org/17050/diff/1/4#newcode117
Line 117: }
However, I suspect you want more than this, since it looks to me like you are
deprecating the OLD_DEV_BRANCH. This won't change the branch from OLD_DEV_BRANCH
to BETA_BRANCH (unless the user hits Save, in which case it will write that
value to the registry). Is this what you want?

http://codereview.chromium.org/17050/diff/1/3
File tools/channel_changer/channel_changer.rc (right):

http://codereview.chromium.org/17050/diff/1/3#newcode42
Line 42: CAPTION "Google Chrome Channel Changer"
By removing the version number there is no way to know which version of the
Channel Changer you are using (and whether you need to update it). If we remove
this, we should add a version resource to this file (which I guess we should do
anyway).

[Mark Larson, 2009-01-05 19:35:32]

http://codereview.chromium.org/17050/diff/1/4
File tools/channel_changer/channel_changer.cc (right):

http://codereview.chromium.org/17050/diff/1/4#newcode114
Line 114: // just declare the user on the Beta channel.
On 2009/01/05 18:07:16, Finnur wrote:
> You have trailing whitespaces at the end of these lines.

Done.

http://codereview.chromium.org/17050/diff/1/4#newcode117
Line 117: }
On 2009/01/05 18:07:16, Finnur wrote:
> However, I suspect you want more than this, since it looks to me like you are
> deprecating the OLD_DEV_BRANCH. This won't change the branch from
OLD_DEV_BRANCH
> to BETA_BRANCH (unless the user hits Save, in which case it will write that
> value to the registry). Is this what you want?

Yes, that's what I want. It seems the simplest solution. 1.1-dev will get
treated as 'beta' by the update rules, so there's no need to jump through hoops
to try to change the registry value to 1.1-beta.

http://codereview.chromium.org/17050/diff/1/3
File tools/channel_changer/channel_changer.rc (right):

http://codereview.chromium.org/17050/diff/1/3#newcode42
Line 42: CAPTION "Google Chrome Channel Changer"
On 2009/01/05 18:07:16, Finnur wrote:
> By removing the version number there is no way to know which version of the
> Channel Changer you are using (and whether you need to update it). If we
remove
> this, we should add a version resource to this file (which I guess we should
do
> anyway).

OK, I'll put 2.0 in as the version number.

[Finnur, 2009-01-05 20:11:13]

In that case: LGTM
(with one nit that was missing from last email)

http://codereview.chromium.org/17050/diff/1/4
File tools/channel_changer/channel_changer.cc (right):

http://codereview.chromium.org/17050/diff/1/4#newcode117
Line 117: }
Hmm... It looks like Rietveld ate one of my comments here:
This is a single line if clause so you don't need the braces.

On 2009/01/05 19:35:32, Mark Larson (Google) wrote:
> On 2009/01/05 18:07:16, Finnur wrote:
> > However, I suspect you want more than this, since it looks to me like you
are
> > deprecating the OLD_DEV_BRANCH. This won't change the branch from
> OLD_DEV_BRANCH
> > to BETA_BRANCH (unless the user hits Save, in which case it will write that
> > value to the registry). Is this what you want?
> 
> Yes, that's what I want. It seems the simplest solution. 1.1-dev will get
> treated as 'beta' by the update rules, so there's no need to jump through
hoops
> to try to change the registry value to 1.1-beta.
> 
>

[Mark Larson, 2009-01-05 20:56:23]

I fixed the braces and submitted as r7559.

http://codereview.chromium.org/17050/diff/1/4
File tools/channel_changer/channel_changer.cc (right):

http://codereview.chromium.org/17050/diff/1/4#newcode117
Line 117: }
On 2009/01/05 20:11:13, Finnur wrote:
> Hmm... It looks like Rietveld ate one of my comments here:
> This is a single line if clause so you don't need the braces.

Braces removed.

> 
> On 2009/01/05 19:35:32, Mark Larson (Google) wrote:
> > On 2009/01/05 18:07:16, Finnur wrote:
> > > However, I suspect you want more than this, since it looks to me like you
> are
> > > deprecating the OLD_DEV_BRANCH. This won't change the branch from
> > OLD_DEV_BRANCH
> > > to BETA_BRANCH (unless the user hits Save, in which case it will write
that
> > > value to the registry). Is this what you want?
> > 
> > Yes, that's what I want. It seems the simplest solution. 1.1-dev will get
> > treated as 'beta' by the update rules, so there's no need to jump through
> hoops
> > to try to change the registry value to 1.1-beta.
> > 
> > 
> 
>