Issue 1705: Bring test shell test into the mac project

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1705: Bring test shell test into the mac project (Closed)

Created:
12 years, 3 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bring test shell test into the mac project Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2017

Patch Set 3 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj	View	1 2	6 chunks	+6 lines, -4 lines	0 comments	Download
	M	webkit/tools/test_shell/test_shell_test.cc	View		3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lucky goldstar http://codereview.chromium.org/1705/diff/203/4 File webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj (right): http://codereview.chromium.org/1705/diff/203/4#newcode1098 Line 1098: ../../../../testing/gtest/include, HEADER_SEARCH_PATHS is replicated in both ...

12 years, 3 months ago (2008-09-10 17:50:43 UTC) #2

Avi (use Gerrit)

12 years, 3 months ago (2008-09-10 20:13:20 UTC) #3

http://codereview.chromium.org/1705/diff/203/4
File webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/1705/diff/203/4#newcode1098
Line 1098: ../../../../testing/gtest/include,
On 2008/09/10 17:50:43, Mark Mentovai wrote:
> HEADER_SEARCH_PATHS is replicated in both the debug and release
configurations,
> but you've only added this to the debug configuration.

D'oh. Fixed.

http://codereview.chromium.org/1705/diff/203/5
File webkit/tools/test_shell/test_shell_test.cc (right):

http://codereview.chromium.org/1705/diff/203/5#newcode37
Line 37: test_shell_->DestroyWindow(test_shell_->mainWnd());
On 2008/09/10 17:50:43, Mark Mentovai wrote:
> Nice!

I knew there was a reason I did it that way :)

Expand Messages | Collapse Messages

Issue 1705: Bring test shell test into the mac project (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages