Issue 1704016: Added support for ES5 date time string format to Date.parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1704016: Added support for ES5 date time string format to Date.parse. (Closed)

Created:
10 years, 7 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev, sandholm

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added support for ES5 date time string format to Date.parse. Committed: http://code.google.com/p/v8/source/detail?r=4557

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -12 lines)			Patch
M	src/date.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/dateparser.h	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	src/dateparser.cc	View	1 2	4 chunks	+15 lines, -1 line	0 comments	Download
M	src/dateparser-inl.h	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download
M	test/mjsunit/date-parse.js	View		3 chunks	+27 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

This corrects issue 41754 (http://crbug.com/41754). The problem is that Date.parse does not recognize date strings ...

10 years, 7 months ago (2010-04-29 12:52:31 UTC) #1

Mads Ager (chromium)

10 years, 7 months ago (2010-04-29 13:24:00 UTC) #2

LGTM

http://codereview.chromium.org/1704016/diff/10001/11001
File test/mjsunit/date-parse.js (right):

http://codereview.chromium.org/1704016/diff/10001/11001#newcode235
test/mjsunit/date-parse.js:235: // Test different version of the ES5 date time
string format
End comments with period.

http://codereview.chromium.org/1704016/diff/10001/11001#newcode271
test/mjsunit/date-parse.js:271: // ES5 date time string format compliance
Ditto.

Expand Messages | Collapse Messages