Issue 1704015: Fix test-debug: make sure debugger is unloaded before running next test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1704015: Fix test-debug: make sure debugger is unloaded before running next test (Closed)

Created:
10 years, 8 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix test-debug: make sure debugger is unloaded before running next test Committed: http://code.google.com/p/v8/source/detail?r=4527

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/debug.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	test/cctest/test-debug.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM But aren't each of the cctests in a separate process?

10 years, 8 months ago (2010-04-28 09:17:29 UTC) #2

yurys

10 years, 8 months ago (2010-04-28 09:43:37 UTC) #3

On 2010/04/28 09:17:29, Søren Gjesse wrote:
> LGTM
> 
> But aren't each of the cctests in a separate process?
IIRC a while ago there were side effects between debugger tests after which
CheckDebuggerUnloaded was added but may be it was true only when the tests were
run from MS VS.

Expand Messages | Collapse Messages