Issue 17032: * switch download manager to using FilePath...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17032: * switch download manager to using FilePath... (Closed)

Created:
11 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
brettw, jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

* switch download manager to using FilePath * add empty() function to FilePath * implement file_util::GetFileExtensionFromPath Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7564

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -177 lines)			Patch
M	base/file_path.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/file_util.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/file_util.cc	View	2 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_file.h	View	4 chunks	+9 lines, -12 lines	0 comments	Download
M	chrome/browser/download/download_file.cc	View	5 chunks	+17 lines, -22 lines	0 comments	Download
M	chrome/browser/download/download_manager.h	View	13 chunks	+34 lines, -30 lines	0 comments	Download
M	chrome/browser/download/download_manager.cc	View	29 chunks	+90 lines, -81 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	5 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/download/save_package.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/history/download_database.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/history/download_types.h	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/views/download_tab_view.cc	View	6 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM