Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 1703012: Fix bug in the ARM full code generator for inlined count operations.... (Closed)

Created:
10 years, 8 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry, antonm
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in the ARM full code generator for inlined count operations. The inlined add needs to set the condition codes to correctly detect smi overflows. Committed: http://code.google.com/p/v8/source/detail?r=4487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
10 years, 8 months ago (2010-04-26 10:13:22 UTC) #1
Erik Corry
10 years, 8 months ago (2010-04-26 10:30:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698