Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6092)

Unified Diff: chrome/browser/printing/printing_layout_uitest.cc

Issue 17030: Revert 7508.7509 and 7510 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/printing_layout_uitest.cc
===================================================================
--- chrome/browser/printing/printing_layout_uitest.cc (revision 7513)
+++ chrome/browser/printing/printing_layout_uitest.cc (working copy)
@@ -457,8 +457,7 @@
dialog_window,
WM_COMMAND,
print_button_id,
- reinterpret_cast<LPARAM>(GetDlgItem(dialog_window,
- print_button_id)));
+ reinterpret_cast<LPARAM>(GetDlgItem(dialog_window, print_button_id)));
// Try again.
if (res)
return;
@@ -499,11 +498,8 @@
return;
// Print a document, check its output.
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
-
- NavigateToURL(server->TestServerPage("files/printing/test1.html"));
+ TestServer server(kDocRoot);
+ NavigateToURL(server.TestServerPage("files/printing/test1.html"));
PrintNowTab();
EXPECT_EQ(0., CompareWithResult(L"test1"));
}
@@ -528,16 +524,13 @@
if (IsTestCaseDisabled())
return;
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
-
+ TestServer server(kDocRoot);
ASSERT_GT(arraysize(kTestPool), 0u);
for (int i = 0; i < arraysize(kTestPool); ++i) {
if (i)
CleanupDumpDirectory();
const TestPool& test = kTestPool[i % arraysize(kTestPool)];
- NavigateToURL(server->TestServerPageW(test.source));
+ NavigateToURL(server.TestServerPageW(test.source));
PrintNowTab();
EXPECT_EQ(0., CompareWithResult(test.result)) << test.result;
CleanupDumpDirectory();
@@ -561,15 +554,13 @@
if (win_util::GetWinVersion() < win_util::WINVERSION_XP)
return;
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
{
scoped_ptr<TabProxy> tab_proxy(GetActiveTab());
ASSERT_TRUE(tab_proxy.get());
bool is_timeout = true;
- GURL url = server->TestServerPage("files/printing/popup_delayed_print.htm");
+ GURL url = server.TestServerPage("files/printing/popup_delayed_print.htm");
EXPECT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS,
tab_proxy->NavigateToURL(url));
@@ -588,7 +579,7 @@
worker->Stop();
// Force a navigation elsewhere to verify that it's fine with it.
- url = server->TestServerPage("files/printing/test1.html");
+ url = server.TestServerPage("files/printing/test1.html");
EXPECT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS,
tab_proxy->NavigateToURL(url));
}
@@ -603,14 +594,12 @@
if (IsTestCaseDisabled())
return;
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
{
scoped_ptr<TabProxy> tab_proxy(GetActiveTab());
ASSERT_TRUE(tab_proxy.get());
- GURL url = server->TestServerPage("files/printing/iframe.htm");
+ GURL url = server.TestServerPage("files/printing/iframe.htm");
EXPECT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS,
tab_proxy->NavigateToURL(url));
@@ -628,7 +617,7 @@
worker->Stop();
// Force a navigation elsewhere to verify that it's fine with it.
- url = server->TestServerPage("files/printing/test1.html");
+ url = server.TestServerPage("files/printing/test1.html");
EXPECT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS,
tab_proxy->NavigateToURL(url));
}
« no previous file with comments | « chrome/browser/login_prompt_uitest.cc ('k') | chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698