Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: chrome/browser/browser_focus_uitest.cc

Issue 17030: Revert 7508.7509 and 7510 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_focus_uitest.cc
===================================================================
--- chrome/browser/browser_focus_uitest.cc (revision 7513)
+++ chrome/browser/browser_focus_uitest.cc (working copy)
@@ -55,12 +55,10 @@
} // namespace
TEST_F(BrowserFocusTest, BrowsersRememberFocus) {
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
// First we navigate to our test page.
- GURL url = server->TestServerPageW(kSimplePage);
+ GURL url = server.TestServerPageW(kSimplePage);
scoped_ptr<TabProxy> tab(GetActiveTab());
EXPECT_NE(AUTOMATION_MSG_NAVIGATION_ERROR, tab->NavigateToURL(url));
@@ -132,9 +130,7 @@
// Tabs remember focus.
TEST_F(BrowserFocusTest, TabsRememberFocus) {
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
scoped_ptr<WindowProxy> window(automation()->GetActiveWindow());
ASSERT_TRUE(window.get() != NULL);
@@ -143,7 +139,7 @@
ASSERT_TRUE(browser.get() != NULL);
// First we navigate to our test page.
- GURL url = server->TestServerPageW(kSimplePage);
+ GURL url = server.TestServerPageW(kSimplePage);
scoped_ptr<TabProxy> tab(GetActiveTab());
tab->NavigateToURL(url);
@@ -198,12 +194,10 @@
// Background window does not steal focus.
TEST_F(BrowserFocusTest, BackgroundBrowserDontStealFocus) {
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
// First we navigate to our test page.
- GURL simple_page_url = server->TestServerPageW(kSimplePage);
+ GURL simple_page_url = server.TestServerPageW(kSimplePage);
scoped_ptr<TabProxy> tab(GetActiveTab());
tab->NavigateToURL(simple_page_url);
@@ -221,7 +215,7 @@
automation()->GetBrowserForWindow(new_window.get()));
ASSERT_TRUE(new_browser.get() != NULL);
- GURL steal_focus_url = server->TestServerPageW(kStealFocusPage);
+ GURL steal_focus_url = server.TestServerPageW(kStealFocusPage);
new_browser->AppendTab(steal_focus_url);
// Make the first browser active
@@ -238,12 +232,10 @@
// Page cannot steal focus when focus is on location bar.
TEST_F(BrowserFocusTest, LocationBarLockFocus) {
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
// Open the page that steals focus.
- GURL url = server->TestServerPageW(kStealFocusPage);
+ GURL url = server.TestServerPageW(kStealFocusPage);
scoped_ptr<TabProxy> tab(GetActiveTab());
tab->NavigateToURL(url);
@@ -272,12 +264,10 @@
// Focus traversal
TEST_F(BrowserFocusTest, FocusTraversal) {
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
// Open the page the test page.
- GURL url = server->TestServerPageW(kTypicalPage);
+ GURL url = server.TestServerPageW(kTypicalPage);
scoped_ptr<TabProxy> tab(GetActiveTab());
tab->NavigateToURL(url);
@@ -347,12 +337,10 @@
// Make sure Find box can request focus, even when it is already open.
TEST_F(BrowserFocusTest, FindFocusTest) {
- scoped_refptr<HTTPTestServer> server =
- HTTPTestServer::CreateServer(kDocRoot);
- ASSERT_TRUE(NULL != server.get());
+ TestServer server(kDocRoot);
// Open some page (any page that doesn't steal focus).
- GURL url = server->TestServerPageW(kTypicalPage);
+ GURL url = server.TestServerPageW(kTypicalPage);
scoped_ptr<TabProxy> tab(GetActiveTab());
tab->NavigateToURL(url);
« no previous file with comments | « no previous file | chrome/browser/browser_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698