Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: net/url_request/url_request_unittest.cc

Issue 17026: Disable FTP tests that are hanging on the bot. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_unittest.h" 5 #include "net/url_request/url_request_unittest.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include <windows.h> 10 #include <windows.h>
(...skipping 909 matching lines...) Expand 10 before | Expand all | Expand 10 after
920 ASSERT_TRUE(NULL != server.get()); 920 ASSERT_TRUE(NULL != server.get());
921 TestDelegate d; 921 TestDelegate d;
922 TestURLRequest req(server->TestServerPage("files/redirect307-to-echoall"), 922 TestURLRequest req(server->TestServerPage("files/redirect307-to-echoall"),
923 &d); 923 &d);
924 req.set_method("POST"); 924 req.set_method("POST");
925 req.Start(); 925 req.Start();
926 MessageLoop::current()->Run(); 926 MessageLoop::current()->Run();
927 EXPECT_EQ(req.method(), "POST"); 927 EXPECT_EQ(req.method(), "POST");
928 } 928 }
929 929
930 #if !defined(OS_WIN) 930 // TODO(ibrar) It appears that these tests are hanging or not shutting down
931 // correctly. Disable them for now.
932 #if 0 // !defined(OS_WIN)
931 #define MAYBE_FTPGetTestAnonymous DISABLED_FTPGetTestAnonymous 933 #define MAYBE_FTPGetTestAnonymous DISABLED_FTPGetTestAnonymous
932 #define MAYBE_FTPCheckWrongPassword DISABLED_FTPCheckWrongPassword 934 #define MAYBE_FTPCheckWrongPassword DISABLED_FTPCheckWrongPassword
933 #define MAYBE_FTPCheckWrongUser DISABLED_FTPCheckWrongUser 935 #define MAYBE_FTPCheckWrongUser DISABLED_FTPCheckWrongUser
934 #define MAYBE_FTPGetTest DISABLED_FTPGetTest 936 #define MAYBE_FTPGetTest DISABLED_FTPGetTest
935 #else 937 #else
936 #define MAYBE_FTPGetTestAnonymous FTPGetTestAnonymous 938 #define MAYBE_FTPGetTestAnonymous FTPGetTestAnonymous
937 #define MAYBE_FTPCheckWrongPassword FTPCheckWrongPassword 939 #define MAYBE_FTPCheckWrongPassword FTPCheckWrongPassword
938 #define MAYBE_FTPCheckWrongUser FTPCheckWrongUser 940 #define MAYBE_FTPCheckWrongUser FTPCheckWrongUser
939 #define MAYBE_FTPGetTest FTPGetTest 941 #define MAYBE_FTPGetTest FTPGetTest
940 #endif 942 #endif
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 int64 file_size = 0; 1033 int64 file_size = 0;
1032 file_util::GetFileSize(app_path, &file_size); 1034 file_util::GetFileSize(app_path, &file_size);
1033 1035
1034 EXPECT_TRUE(!r.is_pending()); 1036 EXPECT_TRUE(!r.is_pending());
1035 EXPECT_EQ(1, d.response_started_count()); 1037 EXPECT_EQ(1, d.response_started_count());
1036 EXPECT_FALSE(d.received_data_before_response()); 1038 EXPECT_FALSE(d.received_data_before_response());
1037 EXPECT_EQ(d.bytes_received(), 0); 1039 EXPECT_EQ(d.bytes_received(), 0);
1038 } 1040 }
1039 } 1041 }
1040 1042
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698