Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/scons/scons-local/SCons/Tool/rpm.py

Issue 17024: Update to SCons 1.2.0. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/scons/scons-local/SCons/Tool/rpm.py
===================================================================
--- third_party/scons/scons-local/SCons/Tool/rpm.py (revision 7505)
+++ third_party/scons/scons-local/SCons/Tool/rpm.py (working copy)
@@ -33,12 +33,12 @@
# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
#
-__revision__ = "src/engine/SCons/Tool/rpm.py 3603 2008/10/10 05:46:45 scons"
+__revision__ = "src/engine/SCons/Tool/rpm.py 3842 2008/12/20 22:59:52 scons"
import os
import re
import shutil
-import popen2
+import subprocess
import SCons.Builder
import SCons.Node.FS
@@ -67,11 +67,12 @@
env.Prepend( RPMFLAGS = '--define \'_topdir %s\'' % tmpdir )
# now call rpmbuild to create the rpm package.
- handle = popen2.Popen3( get_cmd(source, env), capturestderr=1 )
- output = handle.fromchild.read()
- #output += handle.childerr.read()
- output = output + handle.childerr.read()
- status = handle.wait()
+ handle = subprocess.Popen(get_cmd(source, env),
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT,
+ shell=True)
+ output = handle.stdout.read()
+ status = handle.wait()
if status:
raise SCons.Errors.BuildError( node=target[0],
« no previous file with comments | « third_party/scons/scons-local/SCons/Tool/rpcgen.py ('k') | third_party/scons/scons-local/SCons/Tool/sgiar.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698