Issue 1702014: adds default board to get_latest_image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1702014: adds default board to get_latest_image (Closed)

Created:
10 years, 7 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

adds default board to get_latest_image

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/scripts/get_latest_image.sh	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

10 years, 7 months ago (2010-04-29 17:21:17 UTC) #2

LGTM

On Thu, Apr 29, 2010 at 10:17 AM, <sosa@chromium.org> wrote:

> Reviewers: cmasone,
>
> Message:
> Split out from last CL
>
> Description:
> adds default board to get_latest_image
>
> Please review this at http://codereview.chromium.org/1702014/show
>
> SVN Base: ssh://git@chromiumos-git//chromeos
>
> Affected files:
>  M src/scripts/get_latest_image.sh
>
>
> Index: src/scripts/get_latest_image.sh
> diff --git a/src/scripts/get_latest_image.sh
> b/src/scripts/get_latest_image.sh
> index
>
edcc1697b58ee501a40a2b3f2b4c6ffbde75bfbe..3cac3ecc73dc64cc019aee74985846a9f4279d6c
> 100755
> --- a/src/scripts/get_latest_image.sh
> +++ b/src/scripts/get_latest_image.sh
> @@ -10,7 +10,10 @@
>  # The path to common.sh should be relative to your script's location.
>  . "$(dirname "$0")/common.sh"
>
> -DEFINE_string board "" "The name of the board to check for images."
> +get_default_board
> +
> +DEFINE_string board "$DEFAULT_BOARD" \
> +  "The name of the board to check for images."
>
>  # Parse command line flags
>  FLAGS "$@" || exit 1
>
>
>

Expand Messages | Collapse Messages