Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1702013: Improve the success rate for inline keyed store on x64... (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse
Modified:
10 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Improve the success rate for inline keyed store on x64 Added a simple new space check on the elements fixed array which can allow updating with other values than smis without updating the remembered set. Also combined the positive smi and range check so that a separate smi check can be avoided when the key is known to be a smi. This is a port of r4543. Committed: http://code.google.com/p/v8/source/detail?r=4547

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -17 lines) Patch
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -0 lines 1 comment Download
M src/x64/codegen-x64.cc View 2 chunks +25 lines, -11 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 7 months ago (2010-04-29 10:46:10 UTC) #1
Lasse Reichstein
10 years, 7 months ago (2010-04-29 12:15:47 UTC) #2
If its faster, LGTM.

http://codereview.chromium.org/1702013/diff/1/2
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/1702013/diff/1/2#newcode103
src/ia32/macro-assembler-ia32.cc:103: ASSERT(cc == equal || cc == not_equal);
Use a boolean instead of only allowing a subset of Condition. Or, preferably,
make an enum with the values INSIDE, OUTSIDE.

Powered by Google App Engine
This is Rietveld 408576698