Add 2 tests for history.

Add 2 tests for history.

testDownloadNoHistory,testRedirectHistory -- from Deepak.

Also, move _DownloadAndWaitForStart (re-used by the new tests) to a common
location.


TEST=python chrome/test/funtional/history.py

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45987

[John Grabowski, 2010-04-28 23:10:02]

LGTM

http://codereview.chromium.org/1702010/diff/1/6
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/1702010/diff/1/6#newcode250
chrome/test/pyautolib/pyauto.py:250: num_downloads =
len(self.GetDownloadsInfo().Downloads())
Idea: logging.warn if URL is not file:// ?  Helps make sure tests aren't flaky.
Perhaps one day we want to start our own web server as part of pyauto tests. 
When doing that, perhaps we can check for "file:// or the local URL" ?

[Nirnimesh, 2010-04-29 00:16:41]

On Wed, Apr 28, 2010 at 4:10 PM, <jrg@chromium.org> wrote:

> LGTM
>
>
>
> http://codereview.chromium.org/1702010/diff/1/6
> File chrome/test/pyautolib/pyauto.py (right):
>
> http://codereview.chromium.org/1702010/diff/1/6#newcode250
> chrome/test/pyautolib/pyauto.py:250: num_downloads =
> len(self.GetDownloadsInfo().Downloads())
> Idea: logging.warn if URL is not file:// ?  Helps make sure tests aren't
> flaky.
>

Done


> Perhaps one day we want to start our own web server as part of pyauto
> tests.  When doing that, perhaps we can check for "file:// or the local
> URL" ?


Yes, that's in my todo list. I intend to fire up a webserver and use a
function call like self.GetHTTPUrlForFile() for a filesystem path.


>
>
> http://codereview.chromium.org/1702010/show
>



-- 
../NiR