Implement UI automation on the Mac....

Implement UI automation on the Mac.

Code is untested.  From gChat:
  me: do you have a good test I can use to make sure mac impl of
    ui_controls for sending events works OK?  Or would you prefer I send
    you CLs to play with and we iterate by hand?
  Joe: I would like the CL to play with to see if I can get it to work
    with the code I wrote

Warning to Joe: mouse moved events currently use the Mac coordinate
frame (0,0 is bottom-left not top-left). That's easy to switch; I'd
like to do whatever is easiest to get WebDriver working.

BUG=26102
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46005

[John Grabowski, 2010-04-23 01:49:32]

Only ui_controls_mac.mm is interesting

[Nirnimesh, 2010-04-23 19:18:34]

LGTM

[Nico, 2010-04-23 19:24:29]

http://codereview.chromium.org/1701006/diff/13002/15010
File chrome/browser/automation/ui_controls.h (right):

http://codereview.chromium.org/1701006/diff/13002/15010#newcode51
chrome/browser/automation/ui_controls.h:51: bool command);
Drive-by: Could this be enums instead of bools? Makes the call sites much more
readable (could even be a mask then).

Obviously not in this CL; just a suggestion.

[John Grabowski, 2010-04-24 01:11:12]

New diffs up.  Changes:
- After discussing with Joe, flip the coordinate frame for Mac so 0,0 is
upper-left
- Tweaks to get views compiling better based on trybot feedback (trybotz rool)

[John Grabowski, 2010-04-24 01:12:24]

http://codereview.chromium.org/1701006/diff/13002/15010
File chrome/browser/automation/ui_controls.h (right):

http://codereview.chromium.org/1701006/diff/13002/15010#newcode51
chrome/browser/automation/ui_controls.h:51: bool command);
On 2010/04/23 19:24:29, Nico wrote:
> Drive-by: Could this be enums instead of bools? Makes the call sites much more
> readable (could even be a mask then).
> 
> Obviously not in this CL; just a suggestion.

That's a good idea; something like SHIFT|ALT would make a lot more sense.  As
you suggested I'll consider that in a different CL; I'm trying to do minimal
changes for Mac bringup and want to keep risk low.

[Joe, 2010-04-27 10:12:56]

I think a command enum should be added to KeyboardCode typedef under
keyboard_codes_win & keyboard_codes_posix.  I also noticed that Shift
and Control are listed but not Alt, maybe that should be added too.

On Fri, Apr 23, 2010 at 6:12 PM,  <jrg@chromium.org> wrote:
>
> http://codereview.chromium.org/1701006/diff/13002/15010
> File chrome/browser/automation/ui_controls.h (right):
>
> http://codereview.chromium.org/1701006/diff/13002/15010#newcode51
> chrome/browser/automation/ui_controls.h:51: bool command);
> On 2010/04/23 19:24:29, Nico wrote:
>>
>> Drive-by: Could this be enums instead of bools? Makes the call sites
>
> much more
>>
>> readable (could even be a mask then).
>
>> Obviously not in this CL; just a suggestion.
>
> That's a good idea; something like SHIFT|ALT would make a lot more
> sense.  As you suggested I'll consider that in a different CL; I'm
> trying to do minimal changes for Mac bringup and want to keep risk low.
>
> http://codereview.chromium.org/1701006/show
>

[John Grabowski, 2010-04-29 00:27:26]

ALT is otherwise known as VKEY_MENU.

Looking into Command I noticed that the posix keys don't match Mac NSEvent
KeyCodes (or even HIToolbox keycodes).  Jay Civelli says these "common"
POSIX keycodes come from WebKit.  If so, it seems unlikely a Command key
would get dispatched down that far, but is possible.  So perhaps that's for
a future CL.

jrg


On Tue, Apr 27, 2010 at 3:12 AM, Joe Mikhail <jmikhail@google.com> wrote:

> I think a command enum should be added to KeyboardCode typedef under
> keyboard_codes_win & keyboard_codes_posix.  I also noticed that Shift
> and Control are listed but not Alt, maybe that should be added too.
>
> On Fri, Apr 23, 2010 at 6:12 PM,  <jrg@chromium.org> wrote:
> >
> > http://codereview.chromium.org/1701006/diff/13002/15010
> > File chrome/browser/automation/ui_controls.h (right):
> >
> > http://codereview.chromium.org/1701006/diff/13002/15010#newcode51
> > chrome/browser/automation/ui_controls.h:51: bool command);
> > On 2010/04/23 19:24:29, Nico wrote:
> >>
> >> Drive-by: Could this be enums instead of bools? Makes the call sites
> >
> > much more
> >>
> >> readable (could even be a mask then).
> >
> >> Obviously not in this CL; just a suggestion.
> >
> > That's a good idea; something like SHIFT|ALT would make a lot more
> > sense.  As you suggested I'll consider that in a different CL; I'm
> > trying to do minimal changes for Mac bringup and want to keep risk low.
> >
> > http://codereview.chromium.org/1701006/show
> >
>

[Joe, 2010-04-29 18:57:23]

LGTM then

On Wed, Apr 28, 2010 at 5:27 PM, John Grabowski <jrg@chromium.org> wrote:
> ALT is otherwise known as VKEY_MENU.
> Looking into Command I noticed that the posix keys don't match Mac NSEvent
> KeyCodes (or even HIToolbox keycodes).  Jay Civelli says these "common"
> POSIX keycodes come from WebKit.  If so, it seems unlikely a Command key
> would get dispatched down that far, but is possible.  So perhaps that's for
> a future CL.
> jrg
>
> On Tue, Apr 27, 2010 at 3:12 AM, Joe Mikhail <jmikhail@google.com> wrote:
>>
>> I think a command enum should be added to KeyboardCode typedef under
>> keyboard_codes_win & keyboard_codes_posix.  I also noticed that Shift
>> and Control are listed but not Alt, maybe that should be added too.
>>
>> On Fri, Apr 23, 2010 at 6:12 PM,  <jrg@chromium.org> wrote:
>> >
>> > http://codereview.chromium.org/1701006/diff/13002/15010
>> > File chrome/browser/automation/ui_controls.h (right):
>> >
>> > http://codereview.chromium.org/1701006/diff/13002/15010#newcode51
>> > chrome/browser/automation/ui_controls.h:51: bool command);
>> > On 2010/04/23 19:24:29, Nico wrote:
>> >>
>> >> Drive-by: Could this be enums instead of bools? Makes the call sites
>> >
>> > much more
>> >>
>> >> readable (could even be a mask then).
>> >
>> >> Obviously not in this CL; just a suggestion.
>> >
>> > That's a good idea; something like SHIFT|ALT would make a lot more
>> > sense.  As you suggested I'll consider that in a different CL; I'm
>> > trying to do minimal changes for Mac bringup and want to keep risk low.
>> >
>> > http://codereview.chromium.org/1701006/show
>> >
>
>

[John Grabowski, 2010-04-29 19:20:11]

Thanks for the LGTM, but... does it work?  What did you try?

jrg

On Thu, Apr 29, 2010 at 11:57 AM, Joe Mikhail <jmikhail@google.com> wrote:

> LGTM then
>
> On Wed, Apr 28, 2010 at 5:27 PM, John Grabowski <jrg@chromium.org> wrote:
> > ALT is otherwise known as VKEY_MENU.
> > Looking into Command I noticed that the posix keys don't match Mac
> NSEvent
> > KeyCodes (or even HIToolbox keycodes).  Jay Civelli says these "common"
> > POSIX keycodes come from WebKit.  If so, it seems unlikely a Command key
> > would get dispatched down that far, but is possible.  So perhaps that's
> for
> > a future CL.
> > jrg
> >
> > On Tue, Apr 27, 2010 at 3:12 AM, Joe Mikhail <jmikhail@google.com>
> wrote:
> >>
> >> I think a command enum should be added to KeyboardCode typedef under
> >> keyboard_codes_win & keyboard_codes_posix.  I also noticed that Shift
> >> and Control are listed but not Alt, maybe that should be added too.
> >>
> >> On Fri, Apr 23, 2010 at 6:12 PM,  <jrg@chromium.org> wrote:
> >> >
> >> > http://codereview.chromium.org/1701006/diff/13002/15010
> >> > File chrome/browser/automation/ui_controls.h (right):
> >> >
> >> > http://codereview.chromium.org/1701006/diff/13002/15010#newcode51
> >> > chrome/browser/automation/ui_controls.h:51: bool command);
> >> > On 2010/04/23 19:24:29, Nico wrote:
> >> >>
> >> >> Drive-by: Could this be enums instead of bools? Makes the call sites
> >> >
> >> > much more
> >> >>
> >> >> readable (could even be a mask then).
> >> >
> >> >> Obviously not in this CL; just a suggestion.
> >> >
> >> > That's a good idea; something like SHIFT|ALT would make a lot more
> >> > sense.  As you suggested I'll consider that in a different CL; I'm
> >> > trying to do minimal changes for Mac bringup and want to keep risk
> low.
> >> >
> >> > http://codereview.chromium.org/1701006/show
> >> >
> >
> >
>

[Joe, 2010-04-29 21:30:15]

I tested with a simple string and it worked but I didn't check unicode

On Thu, Apr 29, 2010 at 12:19 PM, John Grabowski <jrg@chromium.org> wrote:
> Thanks for the LGTM, but... does it work?  What did you try?
> jrg
>
> On Thu, Apr 29, 2010 at 11:57 AM, Joe Mikhail <jmikhail@google.com> wrote:
>>
>> LGTM then
>>
>> On Wed, Apr 28, 2010 at 5:27 PM, John Grabowski <jrg@chromium.org> wrote:
>> > ALT is otherwise known as VKEY_MENU.
>> > Looking into Command I noticed that the posix keys don't match Mac
>> > NSEvent
>> > KeyCodes (or even HIToolbox keycodes).  Jay Civelli says these "common"
>> > POSIX keycodes come from WebKit.  If so, it seems unlikely a Command key
>> > would get dispatched down that far, but is possible.  So perhaps that's
>> > for
>> > a future CL.
>> > jrg
>> >
>> > On Tue, Apr 27, 2010 at 3:12 AM, Joe Mikhail <jmikhail@google.com>
>> > wrote:
>> >>
>> >> I think a command enum should be added to KeyboardCode typedef under
>> >> keyboard_codes_win & keyboard_codes_posix.  I also noticed that Shift
>> >> and Control are listed but not Alt, maybe that should be added too.
>> >>
>> >> On Fri, Apr 23, 2010 at 6:12 PM,  <jrg@chromium.org> wrote:
>> >> >
>> >> > http://codereview.chromium.org/1701006/diff/13002/15010
>> >> > File chrome/browser/automation/ui_controls.h (right):
>> >> >
>> >> > http://codereview.chromium.org/1701006/diff/13002/15010#newcode51
>> >> > chrome/browser/automation/ui_controls.h:51: bool command);
>> >> > On 2010/04/23 19:24:29, Nico wrote:
>> >> >>
>> >> >> Drive-by: Could this be enums instead of bools? Makes the call sites
>> >> >
>> >> > much more
>> >> >>
>> >> >> readable (could even be a mask then).
>> >> >
>> >> >> Obviously not in this CL; just a suggestion.
>> >> >
>> >> > That's a good idea; something like SHIFT|ALT would make a lot more
>> >> > sense.  As you suggested I'll consider that in a different CL; I'm
>> >> > trying to do minimal changes for Mac bringup and want to keep risk
>> >> > low.
>> >> >
>> >> > http://codereview.chromium.org/1701006/show
>> >> >
>> >
>> >
>
>