bsd: refactor XDG bits of linux_util into a shared file.

bsd: refactor XDG bits of linux_util into a shared file.

This allows the shared code to build on the BSDs without
them needing to build _linux files.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45380

[willchan no longer on Chromium, 2010-04-22 23:01:17]

LGTM

http://codereview.chromium.org/1701005/diff/1/3
File base/base.gyp (right):

http://codereview.chromium.org/1701005/diff/1/3#newcode174
base/base.gyp:174: 'xdg_util_unittest.cc',
It's unfortunate your changelist didn't show the delete of linux_util_unittest. 
I was confused.

http://codereview.chromium.org/1701005/diff/1/7
File base/file_util_posix.cc (right):

http://codereview.chromium.org/1701005/diff/1/7#newcode25
base/file_util_posix.cc:25: #include <glib.h>
What's this for?

http://codereview.chromium.org/1701005/diff/1/7#newcode734
base/file_util_posix.cc:734: const char* home_dir = getenv("HOME");
I think you need <stdlib.h> for getenv.

http://codereview.chromium.org/1701005/diff/1/12
File base/xdg_util.h (right):

http://codereview.chromium.org/1701005/diff/1/12#newcode8
base/xdg_util.h:8: // XDG refers to http://en.wikipedia.org/wiki/Freedesktop.org
.
Why's there a space before the period?

http://codereview.chromium.org/1701005/diff/1/13
File base/xdg_util_unittest.cc (right):

http://codereview.chromium.org/1701005/diff/1/13#newcode31
base/xdg_util_unittest.cc:31: TEST(LinuxUtilTest, GetDesktopEnvironmentGnome) {
These probably should be renamed to XdgUtilTest.

[Evan Martin, 2010-04-22 23:17:40]

http://codereview.chromium.org/1701005/diff/1/12
File base/xdg_util.h (right):

http://codereview.chromium.org/1701005/diff/1/12#newcode8
base/xdg_util.h:8: // XDG refers to http://en.wikipedia.org/wiki/Freedesktop.org
.
Because it's not part of the URL

[Evan Martin, 2010-04-22 23:24:31]

+sprewell FYI

[willchan no longer on Chromium, 2010-04-22 23:26:24]

http://codereview.chromium.org/1701005/diff/1/12
File base/xdg_util.h (right):

http://codereview.chromium.org/1701005/diff/1/12#newcode8
base/xdg_util.h:8: // XDG refers to http://en.wikipedia.org/wiki/Freedesktop.org
.
On 2010/04/22 23:17:40, Evan Martin wrote:
> Because it's not part of the URL

Interesting, I haven't seen this done before.  Doing a grep (git gs "http://" |
grep "// ") through the code base, I see several instances where there is no
space between the URL and the '.', and none to the contrary.  My grep isn't
super accurate, but my very very rough heuristic is this is the less common
convention.  Not a big deal though.