Fix the test server to be smarter about when to...

Fix the test server to be smarter about when to
handle a command or not.

This is to fix this problem:

Adding a new command called "slowread" will not work
if added after "slow", because the handler for "slow"
handles all the commands that STARTS with slow, instead
of slow[/?$]

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7515

[Pam (message me for reviews), 2008-12-30 01:22:01]

http://codereview.chromium.org/17009/diff/1/2
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/17009/diff/1/2#newcode119
Line 119: pattern = re.compile('^%s($|\?|/)' % handler_name)
It'd be clearer to use [] for single-character choices:

'^%s[\?/$]' % handler_name

And if you use match() rather than search(), you can skip the ^ at the
beginning, since match will start matching at the beginning of the string.

http://codereview.chromium.org/17009/diff/1/2#newcode315
Line 315: 
nit: extra blank line

http://codereview.chromium.org/17009/diff/1/2#newcode422
Line 422: if not self._ShouldHandleRequest("/echoall"):
Unlike the "startswith" cases below, these are significantly changing the
behavior (requiring the flags at the beginning of the path).  I don't know that
much about how this testserver is used -- I assume you've made sure that's OK?

[Pam (message me for reviews), 2008-12-30 21:50:29]

LGTM.

- Pam